src/x64/full-codegen-x64.cc - Issue 1007783002: Remove --harmony-scoping flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 1007783002: Remove --harmony-scoping flag. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: CR feedback Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index faaf683278d4e68dd9a6d508c5b0af5bcee8c5b8..ff42e9e04833e16d8a917b1178a63fa2ef394f3f 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -187,7 +187,7 @@ void FullCodeGenerator::Generate() {

Comment cmnt(masm_, "[ Allocate context");

bool need_write_barrier = true;

// Argument to NewContext is the function, which is still in rdi.

- if (FLAG_harmony_scoping && info->scope()->is_script_scope()) {

+ if (info->scope()->is_script_scope()) {

__ Push(rdi);

__ Push(info->scope()->GetScopeInfo(info->isolate()));

__ CallRuntime(Runtime::kNewScriptContext, 2);

« no previous file with comments | « src/scanner.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »