Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1007783002: Remove --harmony-scoping flag. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-scoping flag. We have been shipping harmony scoping for 2 Chrome releases now (M41 and M42). Time to remove the flag. R=rossberg@chromium.org LOG=Y Committed: https://crrev.com/92138c73a74003fa84d9426e2c7be06a16988e0c Cr-Commit-Position: refs/heads/master@{#27187}

Patch Set 1 #

Patch Set 2 : Remove obsolete tests #

Patch Set 3 : Tests moved #

Total comments: 34

Patch Set 4 : Rebase #

Patch Set 5 : Update mjsunit.status #

Total comments: 9

Patch Set 6 : CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -3445 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 2 3 4 5 3 chunks +17 lines, -21 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 2 3 4 5 11 chunks +18 lines, -32 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/preparser.h View 1 2 3 4 5 3 chunks +1 line, -7 lines 0 comments Download
M src/preparser.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/scanner.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/scanner.cc View 5 chunks +68 lines, -74 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-jsops.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-run-variables.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-decls.cc View 1 2 3 15 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/test-parsing.cc View 22 chunks +13 lines, -33 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/bugs/harmony/debug-blockscopes.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/block-conflicts.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-const-assign.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/block-early-errors.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-for.js View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/es6/block-leave.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-let-crankshaft.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/block-let-declaration.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-let-semantics.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/block-non-strict-errors.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/block-scoping.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/debug-blockscopes.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/debug-evaluate-blockscopes.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/debug-function-scopes.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/es6/empty-for.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/iteration-semantics.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/iteration-syntax.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-2243.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-2322.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-2506.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-2858.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-3426.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-3683.js View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-3741.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/function-length-accessor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/block-conflicts.js View 1 2 1 chunk +0 lines, -167 lines 0 comments Download
M test/mjsunit/harmony/block-const-assign.js View 1 2 1 chunk +0 lines, -160 lines 0 comments Download
M test/mjsunit/harmony/block-early-errors.js View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
M test/mjsunit/harmony/block-for.js View 1 2 1 chunk +0 lines, -176 lines 0 comments Download
M test/mjsunit/harmony/block-leave.js View 1 2 1 chunk +0 lines, -226 lines 0 comments Download
M test/mjsunit/harmony/block-let-crankshaft.js View 1 2 1 chunk +0 lines, -484 lines 0 comments Download
M test/mjsunit/harmony/block-let-declaration.js View 1 2 1 chunk +0 lines, -159 lines 0 comments Download
M test/mjsunit/harmony/block-let-semantics.js View 1 2 1 chunk +0 lines, -189 lines 0 comments Download
M test/mjsunit/harmony/block-non-strict-errors.js View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
M test/mjsunit/harmony/block-scoping.js View 1 2 1 chunk +0 lines, -271 lines 0 comments Download
M test/mjsunit/harmony/debug-blockscopes.js View 1 2 1 chunk +0 lines, -504 lines 0 comments Download
M test/mjsunit/harmony/debug-evaluate-blockscopes.js View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
M test/mjsunit/harmony/debug-function-scopes.js View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
M test/mjsunit/harmony/empty-for.js View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
M test/mjsunit/harmony/module-linking.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/module-resolution.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regress/regress-2243.js View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-2322.js View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-2858.js View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-3426.js View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-3683.js View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
M test/mjsunit/harmony/regress/regress-3741.js View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2506.js View 1 2 3 4 5 1 chunk +0 lines, -78 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 2 chunks +1 line, -15 lines 0 comments Download
D test/preparser/strict-const.js View 1 chunk +0 lines, -31 lines 0 comments Download
M test/preparser/strict-function-statement.pyt View 1 1 chunk +0 lines, -109 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 9 months ago (2015-03-13 12:19:05 UTC) #1
rossberg
You should also promote all relevant tests from harmony/ to es6/ then.
5 years, 9 months ago (2015-03-13 12:20:41 UTC) #2
Dmitry Lomov (no reviews)
On 2015/03/13 12:20:41, rossberg wrote: > You should also promote all relevant tests from harmony/ ...
5 years, 9 months ago (2015-03-13 13:09:06 UTC) #3
Dmitry Lomov (no reviews)
ptal, this change will get stale fast
5 years, 9 months ago (2015-03-13 14:03:45 UTC) #4
arv (Not doing code reviews)
LGTM There is some more cleanup that can be done but it can be done ...
5 years, 9 months ago (2015-03-13 14:19:43 UTC) #6
rossberg
The regressoin tests shouldmove to es6/regress. Other than that, only nits. https://codereview.chromium.org/1007783002/diff/40001/src/flag-definitions.h File src/flag-definitions.h (right): ...
5 years, 9 months ago (2015-03-13 14:24:33 UTC) #7
Dmitry Lomov (no reviews)
Thanks for reviews and for meticulous flagging of all empty flags! git grep -e 'Flags:\s\+$' ...
5 years, 9 months ago (2015-03-13 14:51:30 UTC) #8
rossberg
On 2015/03/13 14:51:30, Dmitry Lomov (chromium) wrote: > Thanks for reviews and for meticulous flagging ...
5 years, 9 months ago (2015-03-13 14:55:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007783002/100001
5 years, 9 months ago (2015-03-13 14:56:45 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-13 15:15:50 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 15:16:10 UTC) #14
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/92138c73a74003fa84d9426e2c7be06a16988e0c
Cr-Commit-Position: refs/heads/master@{#27187}

Powered by Google App Engine
This is Rietveld 408576698