Chromium Code Reviews

Issue 1007773002: Improve debuggability of failed GCState transitions. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Improve debuggability of failed GCState transitions. Make use of the call stack to help diagnose unexpected GCState transitions. R=haraken BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191841

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+39 lines, -7 lines)
M Source/platform/heap/ThreadState.cpp View 2 chunks +39 lines, -7 lines 1 comment

Messages

Total messages: 6 (2 generated)
sof
please take a look. https://codereview.chromium.org/1007773002/diff/1/Source/platform/heap/ThreadState.cpp File Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/1007773002/diff/1/Source/platform/heap/ThreadState.cpp#newcode637 Source/platform/heap/ThreadState.cpp:637: UNEXPECTED_GCSTATE(NoGCScheduled); The presubmit script enforced ...
5 years, 9 months ago (2015-03-13 10:49:32 UTC) #2
haraken
LGTM, nice idea.
5 years, 9 months ago (2015-03-13 11:03:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007773002/1
5 years, 9 months ago (2015-03-13 11:10:32 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 13:19:40 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191841

Powered by Google App Engine