Source/bindings/modules/v8/V8BindingForModulesTest.cpp - Issue 1007703003: [bindings] Utilize ScriptValue::from and remove IDB* => ScriptValue conversion methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/v8/V8BindingForModulesTest.cpp

Issue 1007703003: [bindings] Utilize ScriptValue::from and remove IDB* => ScriptValue conversion methods (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/modules/v8/V8BindingForModules.cpp ('K') | « Source/bindings/modules/v8/V8BindingForModules.cpp ('k') | Source/modules/indexeddb/IDBCursor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/v8/V8BindingForModulesTest.cpp

diff --git a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

index a218671f03e9f7c74ae4108d32cbd90f1996c3f8..f4aee33bcaf6129e65a91091f5365d16fcf48b93 100644

--- a/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

+++ b/Source/bindings/modules/v8/V8BindingForModulesTest.cpp

@@ -28,6 +28,7 @@

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8PerIsolateData.h"

+#include "bindings/modules/v8/ToV8ForModules.h"

#include "modules/indexeddb/IDBKey.h"

#include "modules/indexeddb/IDBKeyPath.h"

#include <gtest/gtest.h>

@@ -53,7 +54,7 @@ bool injectKey(ScriptState* scriptState, IDBKey* key, ScriptValue& value, const

{

IDBKeyPath idbKeyPath(keyPath);

EXPECT_TRUE(idbKeyPath.isValid());

- ScriptValue keyValue = idbKeyToScriptValue(scriptState, key);

+ ScriptValue keyValue = ScriptValue::from(scriptState, key);

return injectV8KeyIntoV8Value(scriptState->isolate(), keyValue.v8Value(), value.v8Value(), idbKeyPath);

}