Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1007683002: Add UseCounters for Element.offset* (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add UseCounters for Element.offset* Add HTMLElement.offset* (which is per spec) to shadow Element.offset*, so that the new counters will only trigger for non-HTML elements. It seems likely that usage could be high without actually implying that removal would break anything, but wait to see the data... BUG=463116 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191864

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-13 04:45:04 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-13 04:50:02 UTC) #3
haraken
I guess the counter could be very high though.
5 years, 9 months ago (2015-03-13 04:50:28 UTC) #4
vivekg
lgtm
5 years, 9 months ago (2015-03-13 04:50:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007683002/1
5 years, 9 months ago (2015-03-13 04:54:45 UTC) #8
philipj_slow
On 2015/03/13 04:50:28, haraken wrote: > I guess the counter could be very high though. ...
5 years, 9 months ago (2015-03-13 04:56:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52107)
5 years, 9 months ago (2015-03-13 12:03:46 UTC) #11
philipj_slow
update test expectations
5 years, 9 months ago (2015-03-13 16:22:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007683002/20001
5 years, 9 months ago (2015-03-13 16:22:55 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 19:42:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191864

Powered by Google App Engine
This is Rietveld 408576698