Issue 1007643002: Fix potential integer overflow in fpdf_render_image.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007643002: Fix potential integer overflow in fpdf_render_image.cpp (Closed)

Created:
5 years, 9 months ago by jun_fang

Modified:
5 years, 9 months ago

Reviewers:
Tom Sepez, Lei Zhang, kai_jing

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	1	2 chunks	+11 lines, -5 lines	0 comments	Download

Total messages: 6 (1 generated)

jun_fang

On 2015/03/13 01:44:01, jun_fang wrote: > Hi Tom, > > Please review this change. How ...

5 years, 9 months ago (2015-03-16 17:36:13 UTC) #3

Tom Sepez

(since it's "potential overflow", we don't expect to be able to make a test, so ...

5 years, 9 months ago (2015-03-16 17:47:17 UTC) #5

jun_fang

5 years, 9 months ago (2015-03-16 17:56:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ae5b85a6d5ca1f3c3abd988f19ddc8bfd904464a (presubmit successful).