Source/core/layout/LayoutBox.h - Issue 1007623003: Fix incorrect percentage top for positioned elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 1007623003: Fix incorrect percentage top for positioned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline.html ('K') | « Source/core/css/LayoutStyleCSSValueMapping.cpp ('k') | Source/core/layout/LayoutBox.cpp » ('j') | Source/core/layout/LayoutBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 0310e4415eaf635a9e75dbe0101ecdaac40ebace..c2e24029b6da45d1ad9fe1bc21b9f70b32a4c3a1 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -476,6 +476,8 @@ public:

virtual void mapRectToPaintInvalidationBacking(const LayoutBoxModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const override;

virtual void invalidatePaintForOverhangingFloats(bool paintAllDescendants);

+ LayoutUnit containingBlockLogicalHeightForComputedStyle() const;

virtual LayoutUnit containingBlockLogicalWidthForContent() const override;

LayoutUnit containingBlockLogicalHeightForContent(AvailableLogicalHeightType) const;