LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline.html - Issue 1007623003: Fix incorrect percentage top for positioned elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline.html

Issue 1007623003: Fix incorrect percentage top for positioned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-expected.txt ('k') | LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline-expected.txt » ('j') | Source/core/layout/LayoutBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 </style>
	mstensho (USE GERRIT) 2015/04/13 21:40:04 Stray terminator. Stray terminator. changseok 2015/04/14 06:27:21 Removed. Show quoted text On 2015/04/13 21:40:04, mstensho wrote: > Stray terminator. Removed.
	3 <span id='outer' style="display:inline; position:relative; border:10px solid red ; margin:20px; padding:30px;">
	mstensho (USE GERRIT) 2015/04/13 21:40:04 Could you please add a line-height declaration her Could you please add a line-height declaration here (line-height:50px, for instance), so that font or font engine differences won't cause different results? changseok 2015/04/14 06:27:21 Done. Show quoted text On 2015/04/13 21:40:04, mstensho wrote: > Could you please add a line-height declaration here (line-height:50px, for > instance), so that font or font engine differences won't cause different > results? Done.
	4 outer

	5 <div id='inner' style="position:absolute; top:50%; background:blue">inner</d iv>

	6 </span>

	7 <script src="../../../resources/js-test.js"></script>

	8 <script>

	9 var outer = document.querySelector("#outer");

	10 var inner = document.querySelector("#inner");

	11 var computedStyle = window.getComputedStyle(inner, null);

	12 shouldBeEqualToString("computedStyle.getPropertyValue('top')", "39px");

	13 </script>

OLD	NEW