LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline.html - Issue 1007623003: Fix incorrect percentage top for positioned elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline.html

Issue 1007623003: Fix incorrect percentage top for positioned elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated CL Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-expected.txt ('k') | LayoutTests/fast/css/getComputedStyle/computed-style-percentage-top-with-position-inline-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <span id='outer' style="display:inline; position:relative; line-height:50px; bor der:10px solid red; margin:20px; padding:30px;">
	mstensho (USE GERRIT) 2015/04/14 09:20:07 Sorry for misleading you, but line-height:50px did Sorry for misleading you, but line-height:50px did no good (line-height is irrelevant, since the span is INSIDE the line). But we need something more here to make the test more reliable. On my machine (Linux) computedStyle.getPropertyValue('top') becomes 39.5px, so the test fails (both with line-height:50px and without). Could you add "font:20px Ahem" instead of "line-height:50px"? Then top becomes 40px, which makes sense (30px + 20px * 50 / 100). changseok 2015/04/14 09:48:28 No problem. Done. Show quoted text On 2015/04/14 09:20:07, mstensho wrote: > Sorry for misleading you, but line-height:50px did no good (line-height is > irrelevant, since the span is INSIDE the line). > > But we need something more here to make the test more reliable. On my machine > (Linux) computedStyle.getPropertyValue('top') becomes 39.5px, so the test fails > (both with line-height:50px and without). > > Could you add "font:20px Ahem" instead of "line-height:50px"? > > Then top becomes 40px, which makes sense (30px + 20px * 50 / 100). No problem. Done.
	3 outer

	4 <div id='inner' style="position:absolute; top:50%; background:blue">inner</d iv>

	5 </span>

	6 <script src="../../../resources/js-test.js"></script>

	7 <script>

	8 var outer = document.querySelector("#outer");

	9 var inner = document.querySelector("#inner");

	10 var computedStyle = window.getComputedStyle(inner, null);

	11 shouldBeEqualToString("computedStyle.getPropertyValue('top')", "39px");

	12 </script>

OLD	NEW