Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1007613005: Fix ll_prof.py for static binaries. (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 9 months ago
Reviewers:
ulan, Yang, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix ll_prof.py for static binaries. BUG= Committed: https://crrev.com/2ffc970bcdc2aae48afe00a64b633f9d02b73590 Cr-Commit-Position: refs/heads/master@{#27213}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Explicitly return false. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M tools/ll_prof.py View 1 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jbramley
5 years, 9 months ago (2015-03-13 13:36:58 UTC) #2
ulan
lgtm https://codereview.chromium.org/1007613005/diff/1/tools/ll_prof.py File tools/ll_prof.py (right): https://codereview.chromium.org/1007613005/diff/1/tools/ll_prof.py#newcode727 tools/ll_prof.py:727: assert process.wait() == 0, "Failed to objdump -h ...
5 years, 9 months ago (2015-03-16 08:58:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007613005/20001
5 years, 9 months ago (2015-03-16 11:08:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007613005/20001
5 years, 9 months ago (2015-03-16 11:09:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 11:34:50 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 11:35:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ffc970bcdc2aae48afe00a64b633f9d02b73590
Cr-Commit-Position: refs/heads/master@{#27213}

Powered by Google App Engine
This is Rietveld 408576698