Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1007593002: Define cc::RendererCapabilities in its own header, fix up includes (Closed)

Created:
5 years, 9 months ago by jamesr
Modified:
5 years, 9 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define cc::RendererCapabilities in its own header, fix up includes cc::RendererCapabilities was defined in cc/trees/layer_tree_host.h which had a few subtle implications. First, cc/output/renderer.h needed to #include layer_tree_host even though cc/output/ logically should not depend on cc/trees/. Second, since layer_tree_host.h includes pretty much the entire world, everything that was #including renderer.h was implicitly pulling in many other headers that it may have used. In the spirit of IWYU these files should either include or forward declare types they use. This puts RendererCapabilities in cc/output/renderer_capabilities and fixes up includes in many other files. R=danakj@chromium.org Committed: https://crrev.com/9b8fda3b7b24371afc2c2ed05d1c6a547cc6a786 Cr-Commit-Position: refs/heads/master@{#320767}

Patch Set 1 #

Total comments: 1

Patch Set 2 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -38 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +3 lines, -1 line 0 comments Download
A cc/output/renderer_capabilities.h View 1 chunk +32 lines, -0 lines 0 comments Download
A cc/output/renderer_capabilities.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M cc/surfaces/display.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_ui_resource_layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/pixel_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +1 line, -18 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +6 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
5 years, 9 months ago (2015-03-12 23:27:10 UTC) #1
danakj
LGTM https://codereview.chromium.org/1007593002/diff/1/cc/BUILD.gn File cc/BUILD.gn (right): https://codereview.chromium.org/1007593002/diff/1/cc/BUILD.gn#newcode288 cc/BUILD.gn:288: "output/renderer_capabilities.cc", Add to the gyp files too please.
5 years, 9 months ago (2015-03-13 17:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007593002/20001
5 years, 9 months ago (2015-03-16 18:06:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 19:11:14 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 19:12:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9b8fda3b7b24371afc2c2ed05d1c6a547cc6a786
Cr-Commit-Position: refs/heads/master@{#320767}

Powered by Google App Engine
This is Rietveld 408576698