Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1007503003: Fixed key event context menu and added tests for coordinate cleanups (Closed)

Created:
5 years, 9 months ago by bokan
Modified:
5 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixed key event context menu and added tests for coordinate cleanups Tests corresponding to fixes for issues found in: https://codereview.chromium.org/967213004 Also fixed an issue I found in the context menu for keyboard based events found while writing the test. The location of the context menu was wrong if nothing was focused. BUG=371902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193641

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixed FirstRectForCharacterRangeWithPinchZoom test #

Patch Set 4 : Fixed FirstREctForCharacter test to work across platforms #

Patch Set 5 : Added null expectation for Mac context menu key test #

Patch Set 6 : Fixed typo in expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -17 lines) Patch
A LayoutTests/fast/events/menu-key-context-menu-document-pinch-zoom.html View 1 2 3 4 1 chunk +134 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/menu-key-context-menu-document-pinch-zoom-expected.txt View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/events/menu-key-context-menu-document-pinch-zoom-expected.txt View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 2 3 4 4 chunks +73 lines, -1 line 0 comments Download
M Source/web/tests/data/canvas-copy-image.html View 1 chunk +1 line, -1 line 0 comments Download
A Source/web/tests/data/email-form.html View 1 chunk +7 lines, -0 lines 0 comments Download
A Source/web/tests/data/sometext.html View 1 chunk +28 lines, -0 lines 0 comments Download
A + Source/web/tests/data/textbox.html View 1 2 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
bokan
5 years, 8 months ago (2015-04-07 20:52:28 UTC) #2
aelias_OOO_until_Jul13
Source/web lgtm. I'd suggest mentioning the context menu change in the first line of the ...
5 years, 8 months ago (2015-04-07 22:55:32 UTC) #4
Rick Byers
Source/core and LayoutTests LGTM
5 years, 8 months ago (2015-04-08 14:52:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007503003/20001
5 years, 8 months ago (2015-04-08 16:37:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50989)
5 years, 8 months ago (2015-04-08 17:35:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007503003/40001
5 years, 8 months ago (2015-04-09 13:18:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/58538)
5 years, 8 months ago (2015-04-09 14:39:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007503003/100001
5 years, 8 months ago (2015-04-11 00:34:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007503003/100001
5 years, 8 months ago (2015-04-13 12:20:04 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 15:20:49 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193641

Powered by Google App Engine
This is Rietveld 408576698