Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1007443002: Update WebView's android framework jar to 5.1.0_r1. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, sgurun-gerrit only
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebView's android framework jar to 5.1.0_r1. Now that Android 5.1 is released, use the Android 5.1.0_r1 release tag from AOSP to build an up-to-date framework jar instead of a snapshot of AOSP master. This removes the need for a manifest recording the exact build used as it's a real tagged release. The new jar was already landed separately in crrev.com/81b497cdc14855e407e4406dac8a47346fa7ce8e as Rietveld doesn't handle large binaries well. BUG=466677 Committed: https://crrev.com/865c7736cb21cbaf7fb7eaed1e58ec35b9ee371b Cr-Commit-Position: refs/heads/master@{#320675}

Patch Set 1 #

Patch Set 2 : Landed the new jar in a separate CL, rebased. #

Patch Set 3 : Add minor gyp tidyup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -520 lines) Patch
M android_webview/android_webview.gyp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M android_webview/apk/system_webview_apk_common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/android_platform/README.chromium View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/android_platform/webview/frameworks_1622219.jar View Binary file 0 comments Download
D third_party/android_platform/webview/frameworks_1622219_manifest.xml View 1 chunk +0 lines, -513 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Torne
5 years, 9 months ago (2015-03-12 17:30:41 UTC) #2
rmcilroy
On 2015/03/12 17:30:41, Torne wrote: lgtm.
5 years, 9 months ago (2015-03-12 17:34:37 UTC) #3
Torne
Added a small gypfile tidyup while I'm here - making the APK name come first ...
5 years, 9 months ago (2015-03-13 12:34:08 UTC) #5
rmcilroy
On 2015/03/13 12:34:08, Torne wrote: > Added a small gypfile tidyup while I'm here - ...
5 years, 9 months ago (2015-03-13 12:37:57 UTC) #6
Primiano Tucci (use gerrit)
LGTM, thanks
5 years, 9 months ago (2015-03-13 16:01:42 UTC) #7
Torne
cc'ing sgurun. we can't land this until the downstream CL to switch away from the ...
5 years, 9 months ago (2015-03-13 17:36:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007443002/40001
5 years, 9 months ago (2015-03-14 23:50:35 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-15 00:14:59 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-15 00:15:25 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/865c7736cb21cbaf7fb7eaed1e58ec35b9ee371b
Cr-Commit-Position: refs/heads/master@{#320675}

Powered by Google App Engine
This is Rietveld 408576698