Issue 1007433003: Add a magic number to settings.dat for better identification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007433003: Add a magic number to settings.dat for better identification (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Add a magic number to settings.dat for better identification. “1” is probably one of the more common things for files to begin with. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/58c7519598b39f58ec2ff1a821ace113f523b0fa

Patch Set 1 #

Total comments: 1

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	client/settings.cc	View		2 chunks	+12 lines, -2 lines	1 comment	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Robert Sesek

https://codereview.chromium.org/1007433003/diff/1/client/settings.cc File client/settings.cc (right): https://codereview.chromium.org/1007433003/diff/1/client/settings.cc#newcode205 client/settings.cc:205: Should we also ensure the padding is 0?

5 years, 9 months ago (2015-03-12 23:26:48 UTC) #3

Mark Mentovai

Nah, I don’t think so, just like we don’t ensure that uploads-enabled is exactly 0 ...

5 years, 9 months ago (2015-03-12 23:33:09 UTC) #4

Mark Mentovai

5 years, 9 months ago (2015-03-12 23:34:10 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
58c7519598b39f58ec2ff1a821ace113f523b0fa (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages