Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: components/autofill/content/browser/wallet/wallet_client.h

Issue 100743006: Fix DCHECK() when updating instruments with no phone number. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcheck Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 // |card_verification_number|. |delegate_| is notified when the request is 158 // |card_verification_number|. |delegate_| is notified when the request is
159 // complete. Used to respond to Risk challenges. 159 // complete. Used to respond to Risk challenges.
160 virtual void AuthenticateInstrument( 160 virtual void AuthenticateInstrument(
161 const std::string& instrument_id, 161 const std::string& instrument_id,
162 const std::string& card_verification_number); 162 const std::string& card_verification_number);
163 163
164 // GetFullWallet retrieves the a FullWallet for the user. 164 // GetFullWallet retrieves the a FullWallet for the user.
165 virtual void GetFullWallet(const FullWalletRequest& full_wallet_request); 165 virtual void GetFullWallet(const FullWalletRequest& full_wallet_request);
166 166
167 // Saves the data in |instrument| and/or |address| to Wallet. |instrument| 167 // Saves the data in |instrument| and/or |address| to Wallet. |instrument|
168 // does not have to be complete if its being used to update an existing 168 // does not have to be complete if it's being used to update an existing
169 // instrument, like in the case of expiration date or address only updates. 169 // instrument, like in the case of expiration date or address only updates.
170 virtual void SaveToWallet(scoped_ptr<Instrument> instrument, 170 // |server_instrument| and |server_address| are the instrument and address to
171 scoped_ptr<Address> address); 171 // be updated on the server (and may be NULL if |instrument| or |address| are
Evan Stade 2013/12/12 02:33:57 s/may be/should be
Dan Beam 2013/12/13 04:06:24 Done.
172 // new data).
173 virtual void SaveToWallet(
174 scoped_ptr<Instrument> instrument,
175 scoped_ptr<Address> address,
176 const WalletItems::MaskedInstrument* server_instrument,
Evan Stade 2013/12/12 02:33:57 nit: can you call these reference_instrument/addre
Dan Beam 2013/12/13 04:06:24 Done.
177 const Address* server_address);
172 178
173 bool HasRequestInProgress() const; 179 bool HasRequestInProgress() const;
174 180
175 // Cancels and clears the current |request_| and |pending_requests_| (if any). 181 // Cancels and clears the current |request_| and |pending_requests_| (if any).
176 void CancelRequests(); 182 void CancelRequests();
177 183
178 size_t user_index() const { return user_index_; } 184 size_t user_index() const { return user_index_; }
179 void set_user_index(size_t user_index) { 185 void set_user_index(size_t user_index) {
180 user_index_ = user_index; 186 user_index_ = user_index;
181 } 187 }
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 263
258 base::WeakPtrFactory<WalletClient> weak_ptr_factory_; 264 base::WeakPtrFactory<WalletClient> weak_ptr_factory_;
259 265
260 DISALLOW_COPY_AND_ASSIGN(WalletClient); 266 DISALLOW_COPY_AND_ASSIGN(WalletClient);
261 }; 267 };
262 268
263 } // namespace wallet 269 } // namespace wallet
264 } // namespace autofill 270 } // namespace autofill
265 271
266 #endif // COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_ 272 #endif // COMPONENTS_AUTOFILL_CONTENT_BROWSER_WALLET_WALLET_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698