Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: build/android/pylib/device/logcat_monitor_test.py

Issue 1007423003: [Android] LogcatMonitor.FindAll returns regex match objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/device/logcat_monitor_test.py
diff --git a/build/android/pylib/device/logcat_monitor_test.py b/build/android/pylib/device/logcat_monitor_test.py
index 7a6bf56d5001b1b2ea7c16acacf1325e10addba1..db397e57a2ef7d124e306efb4f0edf505803bac8 100755
--- a/build/android/pylib/device/logcat_monitor_test.py
+++ b/build/android/pylib/device/logcat_monitor_test.py
@@ -50,11 +50,11 @@ class LogcatMonitorTest(unittest.TestCase):
self.assertIsNotNone(
actual,
msg='actual is missing elements starting with %s' % str(expected))
- self.assertEqual(actual.proc_id, expected[0])
- self.assertEqual(actual.thread_id, expected[1])
- self.assertEqual(actual.log_level, expected[2])
- self.assertEqual(actual.component, expected[3])
- self.assertEqual(actual.message, expected[4])
+ self.assertEqual(actual.group('proc_id'), expected[0])
+ self.assertEqual(actual.group('thread_id'), expected[1])
+ self.assertEqual(actual.group('log_level'), expected[2])
+ self.assertEqual(actual.group('component'), expected[3])
+ self.assertEqual(actual.group('message'), expected[4])
with self.assertRaises(StopIteration):
next(actual_iter)
« build/android/pylib/device/logcat_monitor.py ('K') | « build/android/pylib/device/logcat_monitor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698