Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1007423003: [Android] LogcatMonitor.FindAll returns regex match objects (Closed)

Created:
5 years, 9 months ago by perezju
Modified:
5 years, 9 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] LogcatMonitor.FindAll returns regex match objects Match objects are more convenient since they would also allow the caller to define further groups to retrieve in the message_regex, or have access to the full line being matched. BUG= Committed: https://crrev.com/b3d3e418b8b7d8c0d7dc13680aebb97283de06d9 Cr-Commit-Position: refs/heads/master@{#321327}

Patch Set 1 #

Total comments: 3

Patch Set 2 : add optional space after component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -23 lines) Patch
M build/android/pylib/device/logcat_monitor.py View 1 3 chunks +12 lines, -18 lines 0 comments Download
M build/android/pylib/device/logcat_monitor_test.py View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
perezju
I did a quick search for logcat_monitor FindAll, and I think I'm the only potential ...
5 years, 9 months ago (2015-03-18 16:21:21 UTC) #2
jbudorick
https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py#newcode101 build/android/pylib/device/logcat_monitor.py:101: Yields: Why is this more useful? Why is it ...
5 years, 9 months ago (2015-03-18 16:58:41 UTC) #3
jbudorick
On 2015/03/18 16:58:41, jbudorick wrote: > https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py > File build/android/pylib/device/logcat_monitor.py (right): > > https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py#newcode101 > ...
5 years, 9 months ago (2015-03-18 17:02:26 UTC) #4
perezju
https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py#newcode101 build/android/pylib/device/logcat_monitor.py:101: Yields: On 2015/03/18 16:58:40, jbudorick wrote: > Why is ...
5 years, 9 months ago (2015-03-18 17:38:41 UTC) #5
jbudorick
https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py File build/android/pylib/device/logcat_monitor.py (right): https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py#newcode101 build/android/pylib/device/logcat_monitor.py:101: Yields: On 2015/03/18 17:38:41, perezju wrote: > On 2015/03/18 ...
5 years, 9 months ago (2015-03-18 17:43:43 UTC) #6
perezju
On 2015/03/18 17:43:43, jbudorick wrote: > https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py > File build/android/pylib/device/logcat_monitor.py (right): > > https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py#newcode101 > ...
5 years, 9 months ago (2015-03-18 17:55:01 UTC) #7
jbudorick
On 2015/03/18 17:55:01, perezju wrote: > On 2015/03/18 17:43:43, jbudorick wrote: > > > https://codereview.chromium.org/1007423003/diff/1/build/android/pylib/device/logcat_monitor.py ...
5 years, 9 months ago (2015-03-18 17:56:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007423003/20001
5 years, 9 months ago (2015-03-19 09:07:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 10:18:32 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 10:19:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3d3e418b8b7d8c0d7dc13680aebb97283de06d9
Cr-Commit-Position: refs/heads/master@{#321327}

Powered by Google App Engine
This is Rietveld 408576698