Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1007403003: [Smart Lock] Display identity provider information in account chooser infobar. (Closed)

Created:
5 years, 9 months ago by melandory
Modified:
5 years, 9 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Display identity provider information in account chooser infobar. Federated credentials have identity provider information (IDP) associated with them. IDP for each of federated credential should be shown in account chooser infobar. BUG=454815 Committed: https://crrev.com/719b83983be9613eb80e99a0bc645776d59b76b3 Cr-Commit-Position: refs/heads/master@{#322539}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java View 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/credential_android.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
melandory
vabr@chromium.org: Please review changes in chrome/browser/password_manager/credential_android.cc newt@chromium.org: Please review changes in chrome/android/java/src/org/chromium/chrome/browser/infobar/AccountChooserInfoBar.java chrome/android/java/src/org/chromium/chrome/browser/password_manager/Credential.java Thanks in ...
5 years, 9 months ago (2015-03-23 17:18:27 UTC) #6
vabr (Chromium)
chrome/browser/password_manager/credential_android.cc LGTM
5 years, 9 months ago (2015-03-24 08:30:31 UTC) #7
newt (away)
Please elaborate a bit in the commit message. I should be able to understand the ...
5 years, 9 months ago (2015-03-25 21:23:33 UTC) #8
newt (away)
after that, lgtm
5 years, 9 months ago (2015-03-25 21:23:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007403003/80001
5 years, 9 months ago (2015-03-27 08:18:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 9 months ago (2015-03-27 08:41:03 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 08:41:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/719b83983be9613eb80e99a0bc645776d59b76b3
Cr-Commit-Position: refs/heads/master@{#322539}

Powered by Google App Engine
This is Rietveld 408576698