Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1007393004: Fix temp variable allocation in await transformation (Closed)

Created:
5 years, 9 months ago by hausner
Modified:
5 years, 9 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Fix temp variable allocation in await transformation The ast transformation re-uses temporary variables between different await expressions in the same function. This fixes a bug where the transformer found and used temporary variables from an outer function scope, overwriting the outer functions values. Fixes issue 22782. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=44526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/ast_transformer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 9 months ago (2015-03-16 22:24:53 UTC) #2
srdjan
LGTM
5 years, 9 months ago (2015-03-16 22:27:10 UTC) #3
hausner
5 years, 9 months ago (2015-03-16 22:33:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r44526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698