Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 1007393002: Update shelldb to work with new sky_sdk (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, rafaelw, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update shelldb to work with new sky_sdk We need to teach shelldb to deploy the Sky SDK and run SkyServer with the right package root. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/af347e322fc1693fcf8cfee6bfa7fad6c3c5148d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M sky/tools/shelldb View 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-16 16:02:53 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-16 16:14:01 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-16 16:15:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af347e322fc1693fcf8cfee6bfa7fad6c3c5148d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698