chrome/browser/ui/search/search_tab_helper.cc - Issue 1007383003: Adds a new UMA histogram to measure the NTP load time since navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 1007383003: Adds a new UMA histogram to measure the NTP load time since navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index a7a6d5822bda8c9bf2d2e206f71576ce8f1ea80d..12bfa9ea7ec64b234c7c784cfbf8c755df95f2e3 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -26,6 +26,7 @@

#include "chrome/browser/ui/omnibox/omnibox_popup_model.h"

#include "chrome/browser/ui/omnibox/omnibox_view.h"

#include "chrome/browser/ui/search/instant_search_prerenderer.h"

+#include "chrome/browser/ui/search/instant_tab.h"

#include "chrome/browser/ui/search/search_ipc_router_policy_impl.h"

#include "chrome/browser/ui/search/search_tab_helper_delegate.h"

#include "chrome/browser/ui/tab_contents/core_tab_helper.h"

@@ -401,6 +402,7 @@ void SearchTabHelper::ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) {

void SearchTabHelper::MostVisitedItemsChanged(

const std::vector<InstantMostVisitedItem>& items) {

+ InstantTab::EmitNtpStatistics(web_contents_);

Mathieu 2015/03/16 19:49:45 Comment why we are emitting statistics at this poi

fserb 2015/03/16 20:08:36 Done.

ipc_router_.SendMostVisitedItems(items);

}