Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 1007383003: Adds a new UMA histogram to measure the NTP load time since navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 /** 6 /**
7 * @fileoverview Rendering for iframed most visited thumbnails. 7 * @fileoverview Rendering for iframed most visited thumbnails.
8 */ 8 */
9 9
10 window.addEventListener('DOMContentLoaded', function() { 10 window.addEventListener('DOMContentLoaded', function() {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 image.onload = function() { 44 image.onload = function() {
45 var link = createMostVisitedLink( 45 var link = createMostVisitedLink(
46 params, data.url, data.title, undefined, data.direction, 46 params, data.url, data.title, undefined, data.direction,
47 data.provider); 47 data.provider);
48 // Use blocker to prevent context menu from showing image-related items. 48 // Use blocker to prevent context menu from showing image-related items.
49 var blocker = document.createElement('span'); 49 var blocker = document.createElement('span');
50 blocker.className = 'blocker'; 50 blocker.className = 'blocker';
51 link.appendChild(blocker); 51 link.appendChild(blocker);
52 link.appendChild(image); 52 link.appendChild(image);
53 displayLink(link); 53 displayLink(link);
54 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE_LOADED);
54 }; 55 };
55 image.onerror = function() { 56 image.onerror = function() {
56 // If no external thumbnail fallback (etfb), and have domain. 57 // If no external thumbnail fallback (etfb), and have domain.
57 if (!params.etfb && data.domain) { 58 if (!params.etfb && data.domain) {
58 showDomainElement(); 59 showDomainElement();
59 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE_FALLBACK); 60 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE_FALLBACK);
60 } else { 61 } else {
61 showEmptyTile(); 62 showEmptyTile();
62 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE_FALLBACK); 63 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE_FALLBACK);
63 } 64 }
64 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_ERROR); 65 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_ERROR);
66 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE_LOADED);
65 }; 67 };
66 image.src = src; 68 image.src = src;
67 } 69 }
68 70
69 if (data.dummy) { 71 if (data.dummy) {
70 showEmptyTile(); 72 showEmptyTile();
71 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE); 73 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE);
72 } else if (data.thumbnailUrl) { 74 } else if (data.thumbnailUrl) {
73 createThumbnail(data.thumbnailUrl); 75 createThumbnail(data.thumbnailUrl);
74 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_TILE); 76 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_TILE);
75 } else if (data.domain) { 77 } else if (data.domain) {
76 showDomainElement(); 78 showDomainElement();
77 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE); 79 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_GRAY_TILE);
78 } else { 80 } else {
79 showEmptyTile(); 81 showEmptyTile();
80 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE); 82 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_EXTERNAL_TILE);
81 } 83 }
82 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE); 84 logEvent(NTP_LOGGING_EVENT_TYPE.NTP_TILE);
83 85
84 // Log an impression if we know the position of the tile. 86 // Log an impression if we know the position of the tile.
85 if (isFinite(params.pos) && data.provider) { 87 if (isFinite(params.pos) && data.provider) {
86 logMostVisitedImpression(parseInt(params.pos, 10), data.provider); 88 logMostVisitedImpression(parseInt(params.pos, 10), data.provider);
87 } 89 }
88 }); 90 });
89 }); 91 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_title.js » ('j') | chrome/browser/ui/search/search_tab_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698