Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1007373003: fix for invalid for loop syntax broke build (Closed)

Created:
5 years, 9 months ago by msarett
Modified:
5 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix for invalid for loop syntax broke build NOTREECHECKS=true NOTRY=true TBR= BUG=skia: Committed: https://skia.googlesource.com/skia/+/fdc310855dbf04ffb33787f5c0d76fef90b303d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/codec/SkCodec.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007373003/1
5 years, 9 months ago (2015-03-16 15:47:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fdc310855dbf04ffb33787f5c0d76fef90b303d4
5 years, 9 months ago (2015-03-16 15:47:58 UTC) #3
egdaniel
5 years, 9 months ago (2015-03-16 17:49:54 UTC) #4
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1015473002/ by egdaniel@google.com.

The reason for reverting is: needed to revert early patch.

Powered by Google App Engine
This is Rietveld 408576698