Use NodeTraversal to iterate over the accessibility nodes

Source/modules/accessibility/AXLayoutObject.cpp

 /*
 * Copyright (C) 2008 Apple Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 2144 matching lines @@
 // meaning that they should be exposed to the AX hierarchy.
 void AXLayoutObject::addHiddenChildren()
 {
     Node* node = this->node();
     if (!node)
         return;
 
     // First do a quick run through to determine if we have any hidden nodes (most often we will not).
     // If we do have hidden nodes, we need to determine where to insert them so they match DOM order as close as possible.
     bool shouldInsertHiddenNodes = false;
-    for (Node* child = node->firstChild(); child; child = child->nextSibling()) {
-        if (!child->layoutObject() && isNodeAriaVisible(child)) {
+    for (Node& child : NodeTraversal::childrenOf(*node)) {
+        if (!child.layoutObject() && isNodeAriaVisible(&child)) {
             shouldInsertHiddenNodes = true;
             break;
         }
     }
 
     if (!shouldInsertHiddenNodes)
         return;
 
     // Iterate through all of the children, including those that may have already been added, and
     // try to insert hidden nodes in the correct place in the DOM order.
     unsigned insertionIndex = 0;
-    for (Node* child = node->firstChild(); child; child = child->nextSibling()) {
-        if (child->layoutObject()) {
+    for (Node& child : NodeTraversal::childrenOf(*node)) {
+        if (child.layoutObject()) {
             // Find out where the last layout sibling is located within m_children.
-            AXObject* childObject = axObjectCache()->get(child->layoutObject());
-            if (childObject && childObject->accessibilityIsIgnored()) {
-                const AccessibilityChildrenVector& children = childObject->children();
-                if (children.size())
-                    childObject = children.last().get();
-                else
-                    childObject = 0;
+            if (AXObject* childObject = axObjectCache()->get(child.layoutObject())) {
+                if (childObject->accessibilityIsIgnored()) {
+                    const AccessibilityChildrenVector& children = childObject->children();
+                    childObject = children.size() ? children.last().get() : 0;
+                }
+                if (childObject)
+                    insertionIndex = m_children.find(childObject) + 1;
+                continue;
             }
-
-            if (childObject)
-                insertionIndex = m_children.find(childObject) + 1;
-            continue;
         }
 
-        if (!isNodeAriaVisible(child))
+        if (!isNodeAriaVisible(&child))
             continue;
 
         unsigned previousSize = m_children.size();
         if (insertionIndex > previousSize)
             insertionIndex = previousSize;
 
-        insertChild(axObjectCache()->getOrCreate(child), insertionIndex);
+        insertChild(axObjectCache()->getOrCreate(&child), insertionIndex);
         insertionIndex += (m_children.size() - previousSize);
     }
 }
 
 void AXLayoutObject::addTextFieldChildren()
 {
     Node* node = this->node();
     if (!isHTMLInputElement(node))
         return;
 
@@ skipping 198 matching lines @@
         if (label && label->layoutObject()) {
             LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementRect();
             result.unite(labelRect);
         }
     }
 
     return result;
 }
 
 } // namespace blink