Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1007323008: [New Tab Page] Change color format used by NTP_DESIGN. (Closed)

Created:
5 years, 9 months ago by huangs
Modified:
5 years, 9 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered, fserb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[New Tab Page] Change color format used by NTP_DESIGN. NTP_DESIGN has 3 colors that were specified in RRGGBBAA format. These values were injected into title.html iframe via query param. The recent fast local NTP takes rgba(r,g,b,a) format. Rather than writing converter from RRGBBAA to 4-component, we simply store NTP_DESIGN colors in 4-component (like themes), and use existing converters in old NTP and fast NTP where needed. Also fixing title color bug in fast NTP. BUG= Committed: https://crrev.com/ff8ceebf8ffd99c303ae634919c5c2c845913439 Cr-Commit-Position: refs/heads/master@{#321993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M chrome/browser/resources/local_ntp/local_ntp.js View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp_design.js View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/resources/local_ntp/local_ntp_fast.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
huangs
PTAL.
5 years, 9 months ago (2015-03-24 04:24:01 UTC) #2
Mathieu
lgtm
5 years, 9 months ago (2015-03-24 13:39:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007323008/1
5 years, 9 months ago (2015-03-24 13:39:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 13:44:15 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:45:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff8ceebf8ffd99c303ae634919c5c2c845913439
Cr-Commit-Position: refs/heads/master@{#321993}

Powered by Google App Engine
This is Rietveld 408576698