DNS Prefetch fix: renderer shouldn't send long hostnames to browser.

DNS Prefetch fix: renderer shouldn't send long hostnames to browser.

R=ttuttle@chromium.org
BUG=464270
Committed: https://crrev.com/5922e15ca3d5c13d576e5d734c588852b509764d
Cr-Commit-Position: refs/heads/master@{#321154}

[mmenke, 2015-03-17 18:57:09]

Sorry, I'm sick, and looking like I may not be in at all this week.  I'll
happily defer to ttuttle (Who's also sick today).

[Deprecated (see juliatuttle), 2015-03-17 21:58:47]

This looks pretty good. It'd be nice if we could verify that the "good" hostname
is being prefetched and the "bad" one isn't, instead of just that exactly one
hostname is being prefetched.

[gunsch, 2015-03-17 23:18:26]

On 2015/03/17 21:58:47, ttuttle wrote:
> This looks pretty good. It'd be nice if we could verify that the "good"
hostname
> is being prefetched and the "bad" one isn't, instead of just that exactly one
> hostname is being prefetched.

Well, the test already verifies that the "good" hostname (chromium.org) is being
prefetched (WaitUntilHostHasBeenRequested), so that plus verifying 'exactly 1'
seems to rule out the negative case. But I have put the long-bad URL explicitly
into the test as well and verified explicitly that it's not requested.

[gunsch, 2015-03-17 23:19:05]

gunsch@chromium.org changed reviewers:
- mmenke@chromium.org

[Deprecated (see juliatuttle), 2015-03-18 02:35:47]

On 2015/03/17 23:18:26, gunsch wrote:
> Well, the test already verifies that the "good" hostname (http://chromium.org)
is being
> prefetched (WaitUntilHostHasBeenRequested), so that plus verifying 'exactly 1'
> seems to rule out the negative case. But I have put the long-bad URL
explicitly
> into the test as well and verified explicitly that it's not requested.

lgtm, thanks!

[gunsch, 2015-03-18 15:23:39]

gunsch@chromium.org changed reviewers:
+ mef@chromium.org

[gunsch, 2015-03-18 15:24:05]

thanks for the review!

@mef, can you take a look for chrome/browser/net/ OWNERS?

[mef, 2015-03-18 16:10:05]

lgtm

[gunsch, 2015-03-18 16:20:57]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-03-18 16:21:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1007323003/20001

[commit-bot: I haz the power, 2015-03-18 17:14:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-18 17:15:17]

Patchset 2 (id:??) landed as
https://crrev.com/5922e15ca3d5c13d576e5d734c588852b509764d
Cr-Commit-Position: refs/heads/master@{#321154}

[deutsch51, 2015-04-09 09:12:43]

deutsch51@gmail.com changed reviewers:
+ deutsch51@gmail.com

[deutsch51, 2015-04-09 09:12:44]

JIM CAMERON / JimprinT

[deutsch51, 2015-04-09 09:12:45]

JIM CAMERON / JimprinT