Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1007313003: Move sunflower to a new directory, make final tweaks to make it all work. (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move sunflower to a new directory, make final tweaks to make it all work. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0dcdd1b3025782e94931955265c15db13e2872ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -558 lines) Patch
M lib/runtime/dart_runtime.js View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/codegen/html_codegen.dart View 2 chunks +3 lines, -12 lines 0 comments Download
D test/codegen/dom.dart View 1 chunk +0 lines, -191 lines 0 comments Download
D test/codegen/expect/dom.js View 1 chunk +0 lines, -41 lines 0 comments Download
D test/codegen/expect/dom.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/html_input.html View 1 chunk +1 line, -5 lines 0 comments Download
M test/codegen/expect/server_mode/html_input.html View 1 chunk +2 lines, -6 lines 0 comments Download
D test/codegen/expect/sunflower.js View 1 chunk +0 lines, -93 lines 0 comments Download
D test/codegen/expect/sunflower.txt View 1 chunk +0 lines, -7 lines 0 comments Download
A + test/codegen/expect/sunflower/dom.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/sunflower/math.png View Binary file 0 comments Download
A + test/codegen/expect/sunflower/sunflower.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/expect/sunflower/sunflower.html View 3 chunks +15 lines, -21 lines 0 comments Download
A + test/codegen/expect/sunflower/sunflower.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/codegen/expect/sunflower/sunflower.txt View 1 chunk +7 lines, -0 lines 0 comments Download
D test/codegen/sunflower.dart View 1 chunk +0 lines, -76 lines 0 comments Download
A + test/codegen/sunflower/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/sunflower/dom.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/sunflower/math.png View Binary file 0 comments Download
A + test/codegen/sunflower/sunflower.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/sunflower/sunflower.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/codegen/sunflower/sunflower.html View 1 chunk +1 line, -10 lines 0 comments Download
M test/codegen_test.dart View 3 chunks +31 lines, -3 lines 0 comments Download
D test/sunflower/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
D test/sunflower/math.png View Binary file 0 comments Download
D test/sunflower/sunflower.css View 1 chunk +0 lines, -50 lines 0 comments Download
D test/sunflower/sunflower.html View 1 chunk +0 lines, -42 lines 0 comments Download
M test/test.sh View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-18 22:44:52 UTC) #2
Jennifer Messerly
lgtm
5 years, 9 months ago (2015-03-18 22:53:47 UTC) #3
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-18 22:54:04 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0dcdd1b3025782e94931955265c15db13e2872ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698