Issue 1007293002: Disable a test that fails under ASan and MSan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007293002: Disable a test that fails under ASan and MSan (Closed)

Created:
5 years, 9 months ago by Timur Iskhodzhanov

Modified:
5 years, 9 months ago

Reviewers:
nasko

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable a test that fails under ASan and MSan It can be flaky in other configurations as well BUG=467483 TBR=nasko Committed: https://crrev.com/992ff715f61e90562983139ac31392b72e716822 Cr-Commit-Position: refs/heads/master@{#320713}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007293002/1

5 years, 9 months ago (2015-03-16 11:27:50 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/992ff715f61e90562983139ac31392b72e716822 Cr-Commit-Position: refs/heads/master@{#320713}

5 years, 9 months ago (2015-03-16 12:45:28 UTC) #5

nasko

5 years, 9 months ago (2015-03-16 18:23:16 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1018443002/ by nasko@chromium.org.

The reason for reverting is: This test is a victim of a bigger issue of main
renderer message loop being used after it is deleted. Details are in
crbug.com/467369.

I've also run the test with ASAN locally and didn't reproduce after a few runs..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages