Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: base/command_line.h

Issue 1007283012: Provide CommandLine::HasSwitch(const char*) to save 76kB in sizes perf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip the case optimization Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/command_line.h
diff --git a/base/command_line.h b/base/command_line.h
index 85d924a8d31dcf743507ceb518a1cddfb91579b7..19df40c4c478bfa9befe59ad9eefc63f5b33c55f 100644
--- a/base/command_line.h
+++ b/base/command_line.h
@@ -143,7 +143,10 @@ class BASE_EXPORT CommandLine {
// Returns true if this command line contains the given switch.
// (Switch names are case-insensitive).
tapted 2015/03/18 08:51:45 This comment isn't really true except on Windows..
+ // The second override provides an optimized version to avoid inlining the
+ // codegen for the string allocation.
bool HasSwitch(const std::string& switch_string) const;
+ bool HasSwitch(const char switch_constant[]) const;
// Returns the value associated with the given switch. If the switch has no
// value or isn't present, this method returns the empty string.
« no previous file with comments | « no previous file | base/command_line.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698