Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1007283006: Make valgrind a bit more happy by zero-terminating/initializing strings. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make valgrind a bit more happy by zero-terminating/initializing strings. Tiny cleanup on the way... Committed: https://crrev.com/e059be3347970464816a3044990a4b1baa5ba4a3 Cr-Commit-Position: refs/heads/master@{#27226}

Patch Set 1 #

Patch Set 2 : Removed useless assignment. Fixed a condition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M src/compiler/graph-visualizer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-16 14:55:13 UTC) #2
Jakob Kummerow
lgtm
5 years, 9 months ago (2015-03-16 15:09:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007283006/20001
5 years, 9 months ago (2015-03-16 15:09:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 15:34:07 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 15:34:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e059be3347970464816a3044990a4b1baa5ba4a3
Cr-Commit-Position: refs/heads/master@{#27226}

Powered by Google App Engine
This is Rietveld 408576698