Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: src/heap/store-buffer.cc

Issue 1007273002: Remove all atomic access from store buffer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index 37326e7e3f116b621ff02d71e77ec2f28dfaa090..4d87336bce3c7f3e24a0407075418a63145acca5 100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -6,7 +6,6 @@
#include "src/v8.h"
-#include "src/base/atomicops.h"
#include "src/counters.h"
#include "src/heap/store-buffer-inl.h"
@@ -434,8 +433,7 @@ void StoreBuffer::ClearInvalidStoreBufferEntries() {
Object** slot = reinterpret_cast<Object**>(*current);
// Use a NoBarrier_Load here since the slot can be in a dead object
// which may be touched by the concurrent sweeper thread.
Jarin 2015/03/16 11:32:59 Update (or remove?) the comment, please.
Hannes Payer (out of office) 2015/03/16 11:55:42 Done.
- Object* object = reinterpret_cast<Object*>(
- base::NoBarrier_Load(reinterpret_cast<base::AtomicWord*>(slot)));
+ Object* object = *slot;
if (heap_->InNewSpace(object)) {
if (heap_->mark_compact_collector()->IsSlotInLiveObject(
reinterpret_cast<HeapObject**>(slot),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698