Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 1007273002: Remove all atomic access from store buffer. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove all atomic access from store buffer. Store buffer does not contain stale pointers anymore. Hence, sweeper threads and store buffer processing does not collide. BUG= Committed: https://crrev.com/497927927125e6af9461848b70f0830b7bc1da99 Cr-Commit-Position: refs/heads/master@{#27217}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/heap/store-buffer.cc View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Hannes Payer (out of office)
5 years, 9 months ago (2015-03-16 10:54:21 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/1007273002/diff/1/src/heap/store-buffer.cc File src/heap/store-buffer.cc (right): https://codereview.chromium.org/1007273002/diff/1/src/heap/store-buffer.cc#newcode435 src/heap/store-buffer.cc:435: // which may be touched by the concurrent ...
5 years, 9 months ago (2015-03-16 11:32:59 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/1007273002/diff/1/src/heap/store-buffer.cc File src/heap/store-buffer.cc (right): https://codereview.chromium.org/1007273002/diff/1/src/heap/store-buffer.cc#newcode435 src/heap/store-buffer.cc:435: // which may be touched by the concurrent sweeper ...
5 years, 9 months ago (2015-03-16 11:55:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007273002/20001
5 years, 9 months ago (2015-03-16 11:55:54 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 12:22:16 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 12:22:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/497927927125e6af9461848b70f0830b7bc1da99
Cr-Commit-Position: refs/heads/master@{#27217}

Powered by Google App Engine
This is Rietveld 408576698