Issue 1007253006: Remove CSSValueList::equals(const CSSValue&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1007253006: Remove CSSValueList::equals(const CSSValue&) (Closed)

Created:
5 years, 9 months ago by Timothy Loh

Modified:
5 years, 9 months ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove CSSValueList::equals(const CSSValue&) This patch removes CSSValueList::equals(const CSSValue&), which allows us to compare [x] == x. This was only returning true in a couple of cases in editing code, due to LayoutStyleCSSValueMapping returning different types to the CSSPropertyParser, which the patch also fixes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191999

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -31 lines)			Patch
M	Source/core/css/CSSValue.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/css/CSSValueList.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSValueList.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/css/LayoutStyleCSSValueMapping.cpp	View	2 chunks	+5 lines, -17 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007253006/1

5 years, 9 months ago (2015-03-17 08:04:17 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 10:58:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191999

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages