Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 1007253005: Add TRACE_EVENT_SAMPLE_WITH_TID_AND_TIMESTAMP to tracing (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
Reviewers:
dsinclair, nduca, yurys
CC:
chromium-reviews, erikwright+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TRACE_EVENT_SAMPLE_WITH_TID_AND_TIMESTAMP to tracing It is going to be used by V8 sampling profiler. BUG=406277 Committed: https://crrev.com/cf1ec84dc656c778fb1b16ade951c4d46cb90b76 Cr-Commit-Position: refs/heads/master@{#320837}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Drop TRACE_EVENT_SCOPE_THREAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M base/trace_event/trace_event.h View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
5 years, 9 months ago (2015-03-16 17:54:43 UTC) #2
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1007253005/diff/1/base/trace_event/trace_event.h File base/trace_event/trace_event.h (right): https://codereview.chromium.org/1007253005/diff/1/base/trace_event/trace_event.h#newcode528 base/trace_event/trace_event.h:528: TRACE_EVENT_SCOPE_THREAD) What does SCOPE_THREAD do here?
5 years, 9 months ago (2015-03-16 17:57:48 UTC) #3
alph
https://codereview.chromium.org/1007253005/diff/1/base/trace_event/trace_event.h File base/trace_event/trace_event.h (right): https://codereview.chromium.org/1007253005/diff/1/base/trace_event/trace_event.h#newcode528 base/trace_event/trace_event.h:528: TRACE_EVENT_SCOPE_THREAD) On 2015/03/16 17:57:48, dsinclair wrote: > What does ...
5 years, 9 months ago (2015-03-16 22:08:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007253005/20001
5 years, 9 months ago (2015-03-16 22:08:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 00:57:33 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:58:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf1ec84dc656c778fb1b16ade951c4d46cb90b76
Cr-Commit-Position: refs/heads/master@{#320837}

Powered by Google App Engine
This is Rietveld 408576698