Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1007253004: Roll gyp to d174d75bf69c682cb62af9187879e01513b35e52 (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll gyp to d174d75bf69c682cb62af9187879e01513b35e52 This picks the following changes: - convert plist and strings to binary for iOS - bump Xcode compatibility version to 46 (Xcode 3.2) - include action inputs in hybrid build - export generator flavor to gyp scripts BUG=None Committed: https://crrev.com/323eb85bb6dabe3fe323fbbfdb3887a7520cc27d Cr-Commit-Position: refs/heads/master@{#320766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
justincohen: can you review? mark: could you do OWNERS review?
5 years, 9 months ago (2015-03-16 16:49:37 UTC) #2
justincohen
lgtm
5 years, 9 months ago (2015-03-16 16:50:08 UTC) #3
Mark Mentovai
LGTM
5 years, 9 months ago (2015-03-16 17:27:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007253004/1
5 years, 9 months ago (2015-03-16 18:15:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 19:10:46 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 19:11:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/323eb85bb6dabe3fe323fbbfdb3887a7520cc27d
Cr-Commit-Position: refs/heads/master@{#320766}

Powered by Google App Engine
This is Rietveld 408576698