Update all callsites to use info for pixelrefs

Update all callsites to use info for pixelrefs

#define SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR in chrome to keep old API signature (for now)

BUG=
R=scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12677

[reed1, 2013-12-13 17:29:46]

should be 1/2 of the rowbytes CL, just including the SkImageInfo parts.

My goal is to be able to land this, with the LEGACY #define enabled (only by
Chrome) to ease the ability to catch the remaining legacy call-sites in chrome.

[scroggo, 2013-12-13 19:17:28]

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
File src/core/SkMallocPixelRef.cpp (right):

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:12: static bool check_info(const SkImageInfo&
info, SkColorTable* ctable) {
I like is_valid better - it makes it clearer what the return value means.

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:87: : SkPixelRef(info)
INHERITED

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:122: return this->info().getSafeSize(fRB);
This doesn't return the actual size allocated (which is unknown in if the caller
used NewDirect).

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMaskFilter.cpp
File src/core/SkMaskFilter.cpp (right):

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMaskFilter.cp...
src/core/SkMaskFilter.cpp:356: if (resultBM->asImageInfo(&info)) {
I think this should be if NOT asImageInfo.

[reed1, 2013-12-13 19:42:30]

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
File src/core/SkMallocPixelRef.cpp (right):

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:12: static bool check_info(const SkImageInfo&
info, SkColorTable* ctable) {
On 2013/12/13 19:17:29, scroggo wrote:
> I like is_valid better - it makes it clearer what the return value means.

Done.

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:87: : SkPixelRef(info)
On 2013/12/13 19:17:29, scroggo wrote:
> INHERITED

Done.

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMallocPixelRe...
src/core/SkMallocPixelRef.cpp:122: return this->info().getSafeSize(fRB);
On 2013/12/13 19:17:29, scroggo wrote:
> This doesn't return the actual size allocated (which is unknown in if the
caller
> used NewDirect).

The caller of this doesn't need that. It needs to know what the safe range of
addresses are for a subset bitmap to reference. Alexi agreed that once this CL
landed, we could possibly remove that virtual entirely, and just do what this is
doing... We'll see.

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMaskFilter.cpp
File src/core/SkMaskFilter.cpp (right):

https://codereview.chromium.org/100723005/diff/40001/src/core/SkMaskFilter.cp...
src/core/SkMaskFilter.cpp:356: if (resultBM->asImageInfo(&info)) {
On 2013/12/13 19:17:29, scroggo wrote:
> I think this should be if NOT asImageInfo.

Done.

[reed1, 2013-12-13 19:42:52]

ptal

[scroggo, 2013-12-13 19:45:11]

On 2013/12/13 19:42:52, reed1 wrote:
> ptal

lgtm

[reed1, 2013-12-13 19:46:14]

Committed patchset #7 manually as r12677 (presubmit successful).