Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1007223002: Re-enable browser_tests that now pass in --site-per-process mode. (Closed)

Created:
5 years, 9 months ago by Charlie Reis
Modified:
5 years, 9 months ago
Reviewers:
jam, alexmos
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable browser_tests that now pass in --site-per-process mode. TBR=jam@chromium.org BUG=417518, 448592, 458204, 458194 TEST=Site Isolation FYI bots stay green. Committed: https://crrev.com/a98a10a49f00269e85fe3aac2c2dc78b2edd4663 Cr-Commit-Position: refs/heads/master@{#320780}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Put one test back in filter #

Patch Set 4 : Put another flaky test back #

Patch Set 5 : Put back another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Alex: Ok, I think these 12 patterns can be removed. (I had to put some ...
5 years, 9 months ago (2015-03-16 18:03:42 UTC) #2
alexmos
LGTM. Great to see the filter getting smaller!
5 years, 9 months ago (2015-03-16 18:14:26 UTC) #3
Charlie Reis
Yep! Glad to be removing things rather than adding them. TBR'ing jam@.
5 years, 9 months ago (2015-03-16 18:20:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007223002/80001
5 years, 9 months ago (2015-03-16 18:21:02 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-16 20:01:09 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:02:06 UTC) #9
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a98a10a49f00269e85fe3aac2c2dc78b2edd4663
Cr-Commit-Position: refs/heads/master@{#320780}

Powered by Google App Engine
This is Rietveld 408576698