content/browser/service_worker/service_worker_provider_host.cc - Issue 1007133002: ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1007133002: ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_context_core.cc ('K') | « content/browser/service_worker/service_worker_context_unittest.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 3054878f8ccbb7c8f038c2201220e66b4dffa1ac..eaa46e36188d8eec529b004942dc71ad7814f567 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -91,10 +91,13 @@ ServiceWorkerProviderHost::ServiceWorkerProviderHost(

// Actual thread id is set when the service worker context gets started.

render_thread_id_ = kInvalidEmbeddedWorkerThreadId;

}

- context_->RegisterClientIDForProviderHost(client_uuid_, this);

+ context_->RegisterProviderHostByClientID(client_uuid_, this);

}

ServiceWorkerProviderHost::~ServiceWorkerProviderHost() {

+ if (context_)

+ context_->UnregisterProviderHostByClientID(client_uuid_);

kinuko 2015/03/16 05:18:51 Somehow I missed to include this in the previous p

// Clear docurl so the deferred activation of a waiting worker

// won't associate the new version with a provider being destroyed.

document_url_ = GURL();