Add gyp file to build third_party/molokocacao.

Add gyp file to build third_party/molokocacao.

This is necessary to remove ui_cocoa_third_party_toolkits target from ui.gyp.

BUG=299841
TEST=None
R=mark@chromium.org,ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239630

[tfarina, 2013-12-09 01:12:32]

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
File third_party/molokocacao/molokocacao.gyp (right):

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:11:
'../../ui/ui.gyp:ui_cocoa_third_party_toolkits',
I know this is no way good. But NSBezierPath+MCAdditions.m is including a file
from third_party/GTM :(

[Mark Mentovai, 2013-12-09 16:52:37]

LG after the first and third changes. #2 is a suggestion for future work.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
File third_party/molokocacao/molokocacao.gyp (right):

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:1: # Copyright 2013 The Chromium
Authors. All rights reserved.
Adjust your --similarity. This should not show up as a file copy to svn.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:11:
'../../ui/ui.gyp:ui_cocoa_third_party_toolkits',
tfarina wrote:
> I know this is no way good. But NSBezierPath+MCAdditions.m is including a file
> from third_party/GTM :(

We’re handling GTM all wrong, by building its files in various targets spread
throughout the tree, instead of building them in a GTM target.

For your next cleanup project, maybe you’d like to tackle that.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
AppKit.framework, not Cocoa.framework.

[Ben Goodger (Google), 2013-12-09 19:18:31]

lgtm

[tfarina, 2013-12-09 21:01:45]

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
File third_party/molokocacao/molokocacao.gyp (right):

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:1: # Copyright 2013 The Chromium
Authors. All rights reserved.
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> Adjust your --similarity. This should not show up as a file copy to svn.

Done.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:11:
'../../ui/ui.gyp:ui_cocoa_third_party_toolkits',
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> tfarina wrote:
> > I know this is no way good. But NSBezierPath+MCAdditions.m is including a
file
> > from third_party/GTM :(
> 
> We’re handling GTM all wrong, by building its files in various targets spread
> throughout the tree, instead of building them in a GTM target.
> 
> For your next cleanup project, maybe you’d like to tackle that.
Yup, that is my next project for this task.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> AppKit.framework, not Cocoa.framework.

Done.

[tfarina, 2013-12-09 21:01:45]

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
File third_party/molokocacao/molokocacao.gyp (right):

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:1: # Copyright 2013 The Chromium
Authors. All rights reserved.
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> Adjust your --similarity. This should not show up as a file copy to svn.

Done.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:11:
'../../ui/ui.gyp:ui_cocoa_third_party_toolkits',
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> tfarina wrote:
> > I know this is no way good. But NSBezierPath+MCAdditions.m is including a
file
> > from third_party/GTM :(
> 
> We’re handling GTM all wrong, by building its files in various targets spread
> throughout the tree, instead of building them in a GTM target.
> 
> For your next cleanup project, maybe you’d like to tackle that.
Yup, that is my next project for this task.

https://codereview.chromium.org/100713005/diff/1/third_party/molokocacao/molo...
third_party/molokocacao/molokocacao.gyp:15:
'$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
On 2013/12/09 16:52:37, Mark Mentovai wrote:
> AppKit.framework, not Cocoa.framework.

Done.

[Mark Mentovai, 2013-12-09 21:03:03]

LGTM

[commit-bot: I haz the power, 2013-12-09 21:34:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/100713005/40001

[commit-bot: I haz the power, 2013-12-10 01:33:05]

Change committed as 239630