content/renderer/render_frame_impl.h - Issue 1007123003: Clear RenderFrameImpl::frame_ pointer after deleting it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1007123003: Clear RenderFrameImpl::frame_ pointer after deleting it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 4863460d6fa04a24ce4446835ff569e889881c8f..a31276bbb6330d999c1e41d79b85f2d93e2c7e6a 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -738,7 +738,9 @@ class CONTENT_EXPORT RenderFrameImpl

RendererCdmManager* GetCdmManager();

#endif

- // Stores the WebLocalFrame we are associated with.

+ // Stores the WebLocalFrame we are associated with. This is null from the

+ // constructor until SetWebFrame is called, and it is null after

+ // frameDetached is called until destruction (which may be asynchronous).

blink::WebLocalFrame* frame_;

base::WeakPtr<RenderViewImpl> render_view_;

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')