Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 1007113002: The history.pushState/replaceState should check for minimum arity exception. (Closed)

Created:
5 years, 9 months ago by Abhijeet Kandalkar Slow
Modified:
5 years, 9 months ago
Reviewers:
haraken, vivekg, Mike West
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

The history.pushState/replaceState should check for minimum arity exception. As per specification [1], only the third argument of pushState() and replaceState() is optional. This implementation throws an exception if arguments are less than two and matches FF behavior. [1] http://www.w3.org/TR/2011/WD-html5-20110113/history.html#dom-history-pushstate BUG=466350 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192095

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M LayoutTests/fast/history/replacestate-nocrash.html View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
A LayoutTests/fast/history/state-object-few-arguements-exception.html View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/history/state-object-few-arguements-exception-expected.txt View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/custom/V8HistoryCustom.cpp View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Abhijeet Kandalkar Slow
Please review patch.
5 years, 9 months ago (2015-03-14 22:20:29 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-15 01:31:52 UTC) #3
vivekg
Please include the specification link in the description to be handy. Also for the description, ...
5 years, 9 months ago (2015-03-16 14:37:28 UTC) #4
Abhijeet Kandalkar Slow
Please review update patch-2 modified as per review comments.
5 years, 9 months ago (2015-03-18 10:45:34 UTC) #5
Abhijeet Kandalkar Slow
https://codereview.chromium.org/1007113002/diff/1/LayoutTests/http/tests/loading/state-object-few-arguements-exception.html File LayoutTests/http/tests/loading/state-object-few-arguements-exception.html (right): https://codereview.chromium.org/1007113002/diff/1/LayoutTests/http/tests/loading/state-object-few-arguements-exception.html#newcode1 LayoutTests/http/tests/loading/state-object-few-arguements-exception.html:1: <html> On 2015/03/16 14:37:28, vivekg_ wrote: > Please use ...
5 years, 9 months ago (2015-03-18 10:46:58 UTC) #6
vivekg
https://codereview.chromium.org/1007113002/diff/20001/Source/bindings/core/v8/custom/V8HistoryCustom.cpp File Source/bindings/core/v8/custom/V8HistoryCustom.cpp (right): https://codereview.chromium.org/1007113002/diff/20001/Source/bindings/core/v8/custom/V8HistoryCustom.cpp#newcode67 Source/bindings/core/v8/custom/V8HistoryCustom.cpp:67: if (info.Length() < 2) { Please try this form: ...
5 years, 9 months ago (2015-03-18 11:11:54 UTC) #7
vivekg
lgtm https://codereview.chromium.org/1007113002/diff/60001/LayoutTests/fast/history/replacestate-nocrash.html File LayoutTests/fast/history/replacestate-nocrash.html (right): https://codereview.chromium.org/1007113002/diff/60001/LayoutTests/fast/history/replacestate-nocrash.html#newcode8 LayoutTests/fast/history/replacestate-nocrash.html:8: Object.prototype.__defineSetter__("foo",function(){history.replaceState("", "")}); nit: Format the above code as: ...
5 years, 9 months ago (2015-03-18 12:36:58 UTC) #8
Abhijeet Kandalkar Slow
Thank you for reviews. https://codereview.chromium.org/1007113002/diff/60001/LayoutTests/fast/history/replacestate-nocrash.html File LayoutTests/fast/history/replacestate-nocrash.html (right): https://codereview.chromium.org/1007113002/diff/60001/LayoutTests/fast/history/replacestate-nocrash.html#newcode8 LayoutTests/fast/history/replacestate-nocrash.html:8: Object.prototype.__defineSetter__("foo",function(){history.replaceState("", "")}); On 2015/03/18 12:36:57, ...
5 years, 9 months ago (2015-03-18 12:42:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007113002/80001
5 years, 9 months ago (2015-03-18 12:42:50 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 14:06:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192095

Powered by Google App Engine
This is Rietveld 408576698