tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart - Issue 1007103003: cps-ir: Merge variables based on set-based liveness and graph coloring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart

Issue 1007103003: cps-ir: Merge variables based on set-based liveness and graph coloring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Missed a few comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart ('K') | « pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart ('k') | tests/language/catch_liveness_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart

diff --git a/tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart b/tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart

index e15bf3e99967ec5b977d5355f326efd27e556869..64515ce5d75c0f178abc058d35ca2b5d053ed5a3 100644

--- a/tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart

+++ b/tests/compiler/dart2js/js_backend_cps_ir_interceptors_test.dart

@@ -37,7 +37,7 @@ main() {

}""",

r"""

function() {

- var l, i, v0, x, j, v1;

+ var l, i, v0, x, j;

l = ["hest", ["h", "e", "s", "t"]];

P.print(J.getInterceptor$as(l).get$length(l));

i = 0;

@@ -48,8 +48,8 @@ function() {

x = J.getInterceptor$as(l).$index(l, i);

j = 0;

while (true) {

- v1 = J.getInterceptor$as(x).get$length(x);

- if (P.identical(J.getInterceptor$n(j).$lt(j, v1), true)) {

+ v0 = J.getInterceptor$as(x).get$length(x);

+ if (P.identical(J.getInterceptor$n(j).$lt(j, v0), true)) {

P.print(J.getInterceptor$as(x).$index(x, j));

j = J.getInterceptor$ns(j).$add(j, 1);

} else {