pkg/compiler/lib/src/js_backend/codegen/task.dart - Issue 1007103003: cps-ir: Merge variables based on set-based liveness and graph coloring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1007103003: cps-ir: Merge variables based on set-based liveness and graph coloring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/dart_backend/dart_backend.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/copy_propagator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/task.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart

index db85809856ceb6ad24979ad4863bfadf7143d86a..d631f286655f710e1b4320367c062ff39a75fd0f 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart

@@ -179,10 +179,6 @@ class CpsFunctionCompiler implements FunctionCompiler {

applyCpsPass(new RedundantPhiEliminator());

applyCpsPass(new ShrinkingReducer());

- // Do not rewrite the IR after variable allocation. Allocation

- // makes decisions based on an approximation of IR variable live

- // ranges that can be invalidated by transforming the IR.

- new cps.RegisterAllocator(compiler.internalError).visit(cpsNode);

return cpsNode;

}

@@ -209,7 +205,7 @@ class CpsFunctionCompiler implements FunctionCompiler {

}

applyTreePass(new StatementRewriter());

- applyTreePass(new CopyPropagator());

+ applyTreePass(new VariableMerger());

applyTreePass(new LoopRewriter());

applyTreePass(new LogicalRewriter());