Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1007083004: SkPDF: eliminate skpdfpage class (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-03-25 (Wednesday) 15:01:10 EDT #

Patch Set 3 : 2015-03-25 (Wednesday) 15:31:19 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -236 lines) Patch
M gyp/pdf.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/doc/SkDocument_PDF.cpp View 1 2 5 chunks +116 lines, -12 lines 0 comments Download
D src/pdf/SkPDFPage.h View 1 chunk +0 lines, -83 lines 0 comments Download
D src/pdf/SkPDFPage.cpp View 1 chunk +0 lines, -139 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007083004/1
5 years, 9 months ago (2015-03-25 18:58:29 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 18:58:30 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCE-NoGPU-x86_64-Debug-Trybot/builds/119) Test-Ubuntu-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 9 months ago (2015-03-25 18:59:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007083004/20001
5 years, 9 months ago (2015-03-25 19:01:40 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-25 19:01:41 UTC) #8
hal.canary
ptal
5 years, 9 months ago (2015-03-25 19:16:29 UTC) #10
mtklein
lgtm
5 years, 9 months ago (2015-03-25 19:18:00 UTC) #11
commit-bot: I haz the power
Failed to apply patch for src/pdf/SkPDFDocument.cpp: While running git apply --index -3 -p1; <stdin>:44: trailing ...
5 years, 9 months ago (2015-03-25 19:19:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007083004/40001
5 years, 9 months ago (2015-03-25 19:32:22 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:45:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2f7ebcb424cd1d1acf07478157f86b0a3eafd712

Powered by Google App Engine
This is Rietveld 408576698