Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1007063003: Revert of Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (Closed)

Created:
5 years, 9 months ago by tommi (sloooow) - chröme
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1025003002/) Reason for revert: Relanding libjingle.gyp update that removes libpeer_target_type references. The issue on Android has been fixed. Original issue's description: > Revert of Clean up libjingle.gyp and remove references to libpeer_target_type. (patchset #1 id:1 of https://codereview.chromium.org/1008023002/) > > Reason for revert: > See if this caused errors on Android. > > Original issue's description: > > Clean up libjingle.gyp and remove references to libpeer_target_type. > > This variable isn't supported any longer. > > > > BUG=446865 > > > > Committed: https://crrev.com/fd22585c501bdd46f0a511fa5346fc9be1b85f88 > > Cr-Commit-Position: refs/heads/master@{#321371} > > TBR=kjellander@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=446865 > > Committed: https://crrev.com/5e83cd0937a248f3d544800797b0dcbcba6eb13b > Cr-Commit-Position: refs/heads/master@{#321614} TBR=kjellander@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=446865 Committed: https://crrev.com/24c0544b3bc53c0513f607d4e6468c3d33f3937e Cr-Commit-Position: refs/heads/master@{#322232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -62 lines) Patch
M third_party/libjingle/libjingle.gyp View 6 chunks +6 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
Created Revert of Revert of Clean up libjingle.gyp and remove references to libpeer_target_type.
5 years, 9 months ago (2015-03-25 20:38:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007063003/1
5 years, 9 months ago (2015-03-25 20:38:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 20:39:44 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/24c0544b3bc53c0513f607d4e6468c3d33f3937e Cr-Commit-Position: refs/heads/master@{#322232}
5 years, 9 months ago (2015-03-25 20:40:42 UTC) #4
kjellander_chromium
5 years, 9 months ago (2015-03-25 20:51:18 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698