Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1007043002: Fix android resources in gn builds (Closed)

Created:
5 years, 9 months ago by cjhopman
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@stack_debug_better
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android resources in gn builds Dependent libraries need to be passed in the reverse order that build_utils.GetSortedTransitiveDependencies returns. Also, a multi-library resource zip in package_libraries should be sorted on the numeric values of the directories in the zip, not the string values. Committed: https://crrev.com/46ba0c2ba3d041ee8dac492be81904ee073f4ed8 Cr-Commit-Position: refs/heads/master@{#320802}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/android/gyp/package_resources.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M build/android/gyp/write_build_config.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
cjhopman
newt: *
5 years, 9 months ago (2015-03-13 23:00:08 UTC) #2
newt (away)
lgtm Of course ;) So which layout resource was being inflated after all? https://codereview.chromium.org/1007043002/diff/1/build/android/gyp/package_resources.py File ...
5 years, 9 months ago (2015-03-13 23:13:45 UTC) #3
cjhopman
https://codereview.chromium.org/1007043002/diff/1/build/android/gyp/package_resources.py File build/android/gyp/package_resources.py (right): https://codereview.chromium.org/1007043002/diff/1/build/android/gyp/package_resources.py#newcode107 build/android/gyp/package_resources.py:107: for s in subdirs: On 2015/03/13 23:13:45, newt wrote: ...
5 years, 9 months ago (2015-03-16 20:04:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007043002/20001
5 years, 9 months ago (2015-03-16 20:05:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 22:04:38 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:05:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46ba0c2ba3d041ee8dac492be81904ee073f4ed8
Cr-Commit-Position: refs/heads/master@{#320802}

Powered by Google App Engine
This is Rietveld 408576698