Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 100703002: Added net::NetworkInterface::interface_index. (Closed)

Created:
7 years ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years ago
Reviewers:
szym, Noam Samuel
CC:
chromium-reviews, cbentzel+watch_chromium.org, Wez, Alpha Left Google
Visibility:
Public.

Description

Added net::NetworkInterface::interface_index. Not implemented for Android. BUG=319068 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238931

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -10 lines) Patch
M chrome/browser/local_discovery/privet_traffic_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 1 2 chunks +10 lines, -5 lines 0 comments Download
M net/base/net_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/net_util.cc View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M net/base/net_util_posix.cc View 1 2 3 chunks +9 lines, -2 lines 0 comments Download
M net/base/net_util_unittest.cc View 1 2 3 chunks +47 lines, -0 lines 0 comments Download
M net/base/net_util_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years ago (2013-12-03 09:39:21 UTC) #1
Vitaly Buka (NO REVIEWS)
7 years ago (2013-12-03 23:06:25 UTC) #2
Noam Samuel
lgtm
7 years ago (2013-12-04 01:04:27 UTC) #3
szym
lgtm https://codereview.chromium.org/100703002/diff/130001/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java File net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java (right): https://codereview.chromium.org/100703002/diff/130001/net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java#newcode146 net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java:146: * the list string are delimited by a ...
7 years ago (2013-12-04 09:28:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/100703002/130001
7 years ago (2013-12-04 09:41:38 UTC) #5
commit-bot: I haz the power
Change committed as 238671
7 years ago (2013-12-04 11:35:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/100703002/190001
7 years ago (2013-12-04 21:09:28 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=231929
7 years ago (2013-12-05 01:47:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/100703002/190001
7 years ago (2013-12-05 07:09:29 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-05 10:58:43 UTC) #10
Message was sent while issue was closed. 
Change committed as 238931

Powered by Google App Engine
This is Rietveld 408576698