PyAuto: Flags to forbid cleaning profile dir...

PyAuto: Flags to forbid cleaning profile dir

Several tests require quitting/killing chromium to test features like
restore. In addition, one might want to use pyauto on an existing profile.
This CL lets pyauto work without cleaning the profile dir.
Also lets specify the homepage to use.

Example: Running this test with CHROME_UI_TESTS_USER_DATA_DIR pointing to a
profile dir will run my script with the given dir as the user-data-dir
without cleaning it up, and also specifies the homepage to use.

class A(PyUITest):
  def __init__(self, methodName):
    PyUITest.__init__(self, methodName, clear_profile=False,
                      homepage="http://www.cnn.com")

  def testA(self):
    pass

BUG=None
TEST=None



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41878

[John Grabowski, 2010-03-16 23:35:27]

http://codereview.chromium.org/1007007/diff/1/3
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1007007/diff/1/3#newcode71
chrome/test/pyautolib/pyauto.py:71: def __init__(self, methodName='runTest',
extra_chrome_flags=None,
we're starting to get an excessive list of args.  Consider using **kw here. 
Still document what you look for tho.

http://codereview.chromium.org/1007007/diff/1/3#newcode82
chrome/test/pyautolib/pyauto.py:82: clear_profile: If True, clean the profile
dir before use. Default: True
Is there a call to get "current profile dir" in case a test wants to confirm
something by looking in there?  Seems like we're starting to walk down that
path; might want to consider profile feature/needs as a whole instead of onesey
twosey.

http://codereview.chromium.org/1007007/diff/1/3#newcode88
chrome/test/pyautolib/pyauto.py:88: pyautolib.PyUITestSuite.__init__(self, args,
clear_profile, homepage)
pass in kw ?

http://codereview.chromium.org/1007007/diff/1/4
File chrome/test/pyautolib/pyautolib.cc (right):

http://codereview.chromium.org/1007007/diff/1/4#newcode16
chrome/test/pyautolib/pyautolib.cc:16: clear_profile_ = clear_profile;
These are member variables of UITestBase, not PyUITestSuite.  So I would guess
we'd want UITestBase's constructor (or a UITestbase method) to set them, not us.

[Nirnimesh, 2010-03-17 00:35:19]

http://codereview.chromium.org/1007007/diff/1/3
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1007007/diff/1/3#newcode71
chrome/test/pyautolib/pyauto.py:71: def __init__(self, methodName='runTest',
extra_chrome_flags=None,
On 2010/03/16 23:35:27, John Grabowski wrote:
> we're starting to get an excessive list of args.  Consider using **kw here. 
> Still document what you look for tho.

Done.

http://codereview.chromium.org/1007007/diff/1/3#newcode82
chrome/test/pyautolib/pyauto.py:82: clear_profile: If True, clean the profile
dir before use. Default: True
On 2010/03/16 23:35:27, John Grabowski wrote:
> Is there a call to get "current profile dir" in case a test wants to confirm
> something by looking in there?

Yes, the user_data_dir() method

>  Seems like we're starting to walk down that
> path; might want to consider profile feature/needs as a whole instead of
onesey
> twosey.

I want to make sure I've covered all the low-hanging fruits. Access to profile
gives us a bunch of other interesting things, which'll require someone to
implement a bunch of hooks.

http://codereview.chromium.org/1007007/diff/1/3#newcode88
chrome/test/pyautolib/pyauto.py:88: pyautolib.PyUITestSuite.__init__(self, args,
clear_profile, homepage)
On 2010/03/16 23:35:27, John Grabowski wrote:
> pass in kw ?
> 

I'm afraid I'd have to name the args here. We're now passing args to the C++
side and it won't be so easy to pass a python dict.

http://codereview.chromium.org/1007007/diff/1/4
File chrome/test/pyautolib/pyautolib.cc (right):

http://codereview.chromium.org/1007007/diff/1/4#newcode16
chrome/test/pyautolib/pyautolib.cc:16: clear_profile_ = clear_profile;
On 2010/03/16 23:35:27, John Grabowski wrote:
> These are member variables of UITestBase, not PyUITestSuite.  So I would guess
> we'd want UITestBase's constructor (or a UITestbase method) to set them, not
us.
>  

Done. Thanks

[John Grabowski, 2010-03-17 01:18:55]

LGTM

http://codereview.chromium.org/1007007/diff/10001/11002
File chrome/test/pyautolib/pyauto.py (right):

http://codereview.chromium.org/1007007/diff/10001/11002#newcode95
chrome/test/pyautolib/pyauto.py:95: if extra_chrome_flags is not None:
"if extra chrome flags:"
(no need for "is not None" unless the empty string is a valid value, which I
don't think it is)

http://codereview.chromium.org/1007007/diff/10001/11004
File chrome/test/pyautolib/pyautolib.h (right):

http://codereview.chromium.org/1007007/diff/10001/11004#newcode29
chrome/test/pyautolib/pyautolib.h:29: // Only public methods are accessible from
swig.
No need to repeat the doc for variables here, but maybe say something like "doc
for these args can be found in pyautolib.py"