Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1007003005: Define SkLONGLONG so that SkLONGLONG code in Skia can be removed. (Closed)

Created:
5 years, 9 months ago by bungeman-chromium
Modified:
5 years, 9 months ago
Reviewers:
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Define SkLONGLONG so that SkLONGLONG code in Skia can be removed. With SkLONGLONG some multiplies floor the low bit, without it these will truncate. Defining this on all platforms means all platforms will have the same behavior and also the deviant behavior can later be removed. Currently, Linux is the only platform which does not define this. This is expected to mean rebaselining ~1200 layout tests on Linux only. Once these are rebaselined, the Skia code using this define will be removed and this define will then be removed as well. BUG=skia:179, chromium:467732 TBR=fmailita@chromium.org,reed@chromium.org NOTRY=true This is 'just' an expectations change. All modifications reviewed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191956

Patch Set 1 #

Patch Set 2 : Add rebaselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1301 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1300 lines, -0 lines 0 comments Download
M public/blink_skia_config.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1007003005/20001
5 years, 9 months ago (2015-03-16 22:55:18 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:55:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191956

Powered by Google App Engine
This is Rietveld 408576698