Publicize registration of MediaUrlInterceptor

Publicize registration of MediaUrlInterceptor

Android WebView needs to register a MediaUrlInterceptor, but should
not depend on content/browser.

BUG=465927
Committed: https://crrev.com/9e5c48d1c32ee4beff1676a56b5f246b3079c52b
Cr-Commit-Position: refs/heads/master@{#321547}

[mnaganov (inactive), 2015-03-13 18:01:49]

mnaganov@chromium.org changed reviewers:
+ qinmin@chromium.org

[mnaganov (inactive), 2015-03-16 20:39:10]

Ping!

[boliu, 2015-03-16 22:37:47]

Min is OOO at the moment

[qinmin, 2015-03-17 18:01:09]

lgtm

[mnaganov (inactive), 2015-03-17 20:52:08]

mnaganov@chromium.org changed reviewers:
+ tedchoc@chromium.org

[mnaganov (inactive), 2015-03-17 20:52:52]

tedchoc@: Ted, can you please take a look at content/public/browser/android
change?

[Ted C, 2015-03-17 21:06:39]

https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
File content/public/browser/android/media_url_interceptor.cc (right):

https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
content/public/browser/android/media_url_interceptor.cc:13:
content::BrowserMediaPlayerManager::RegisterMediaUrlInterceptor(
Any reason to not add a content/public .h for browser_media_player_manager (and
only have this method defined there)?

[mnaganov (inactive), 2015-03-18 11:17:48]

https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
File content/public/browser/android/media_url_interceptor.cc (right):

https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
content/public/browser/android/media_url_interceptor.cc:13:
content::BrowserMediaPlayerManager::RegisterMediaUrlInterceptor(
On 2015/03/17 21:06:39, Ted C wrote:
> Any reason to not add a content/public .h for browser_media_player_manager
(and
> only have this method defined there)?

My concern was that this would imply introducing an abstract
BrowserMediaPlayerManager class and renaming the existing
BrowserMediaPlayerManager into BrowserMediaPlayerManagerImpl for no good reason.

But as the method we need to export is static, a compromise solution I've
employed is adding public/browser/android/browser_media_player_manager.h/cc, but
defining a plain function there, so no class renaming is needed. Does this look
better to you?

[mnaganov (inactive), 2015-03-19 19:11:23]

On 2015/03/18 11:17:48, mnaganov (cr) wrote:
>
https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
> File content/public/browser/android/media_url_interceptor.cc (right):
> 
>
https://codereview.chromium.org/1006973002/diff/20001/content/public/browser/...
> content/public/browser/android/media_url_interceptor.cc:13:
> content::BrowserMediaPlayerManager::RegisterMediaUrlInterceptor(
> On 2015/03/17 21:06:39, Ted C wrote:
> > Any reason to not add a content/public .h for browser_media_player_manager
> (and
> > only have this method defined there)?
> 
> My concern was that this would imply introducing an abstract
> BrowserMediaPlayerManager class and renaming the existing
> BrowserMediaPlayerManager into BrowserMediaPlayerManagerImpl for no good
reason.
> 
> But as the method we need to export is static, a compromise solution I've
> employed is adding public/browser/android/browser_media_player_manager.h/cc,
but
> defining a plain function there, so no class renaming is needed. Does this
look
> better to you?

Ted, could you please take a look?

[Ted C, 2015-03-19 21:11:47]

lgtm -- seems reasonable to me.

[mnaganov (inactive), 2015-03-20 09:47:00]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2015-03-20 09:47:00]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/1006973002/#ps40001
(title: "Rename the interface file")

[commit-bot: I haz the power, 2015-03-20 09:47:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1006973002/40001

[commit-bot: I haz the power, 2015-03-20 11:01:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-20 11:02:22]

Patchset 3 (id:??) landed as
https://crrev.com/9e5c48d1c32ee4beff1676a56b5f246b3079c52b
Cr-Commit-Position: refs/heads/master@{#321547}